Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev UI - handle file: protocol when locating /dev-templates #17007

Merged
merged 1 commit into from
May 7, 2021
Merged

Dev UI - handle file: protocol when locating /dev-templates #17007

merged 1 commit into from
May 7, 2021

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented May 5, 2021

@mkouba mkouba requested a review from FroMage May 5, 2021 12:45
@quarkus-bot
Copy link

quarkus-bot bot commented May 5, 2021 •
edited
Loading

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 5ee9a6e

Status Name Step Test failures Logs Raw logs
✔️ JVM Tests - JDK 11
✖ JVM Tests - JDK 11 Windows Build Test failures Logs Raw logs
✔️ JVM Tests - JDK 15

Full information is available in the Build summary check run.

Test Failures

⚙️ JVM Tests - JDK 11 Windows #

📦 extensions/vertx-http/deployment

✖ io.quarkus.vertx.http.devconsole.DevConsoleConfigEditorBodyHandlerTest.testChangeHttpRoute - More details - Source on GitHub

✖ io.quarkus.vertx.http.devconsole.DevConsoleConfigEditorTest.testChangeHttpRoute - More details - Source on GitHub

✖ io.quarkus.vertx.http.devconsole.DevConsoleConfigEditorTest.testSetEmptyValue - More details - Source on GitHub

✖ io.quarkus.vertx.http.devmode.ArcEndpointTest.testBeans - More details - Source on GitHub

✖ io.quarkus.vertx.http.devmode.LiveReloadArtifactTest.test - More details - Source on GitHub

✖ io.quarkus.vertx.http.devmode.ParentFirstArtifactTest.test - More details - Source on GitHub

✖ io.quarkus.vertx.http.hotreload.HotReloadWithFilterTest.testFilterChange - More details - Source on GitHub

✖ io.quarkus.vertx.http.hotreload.HotReloadWithFilterTest.testAddFilter - More details - Source on GitHub

✖ io.quarkus.vertx.http.hotreload.HotReloadWithRouteTest.testAddBean - More details - Source on GitHub

✖ io.quarkus.vertx.http.hotreload.HotReloadWithRouteTest.testRouteChange - More details - Source on GitHub

✖ io.quarkus.vertx.http.hotreload.VertxInjectionTest.testEditingBeanUsingVertx - More details - Source on GitHub

✖ io.quarkus.vertx.http.testrunner.QuarkusTestTypeTestCase.testQuarkusTestMode - More details - Source on GitHub

✖ io.quarkus.vertx.http.testrunner.TestChangeTrackingWhenStartFailsTestCase.testChangeTrackingOnStartupFailure - More details - Source on GitHub

✖ io.quarkus.vertx.http.testrunner.TestRunnerSmokeTestCase.checkTestsAreRun - More details - Source on GitHub

✖ io.quarkus.vertx.http.testrunner.UnitTestTypeTestCase.testUnitMode - More details - Source on GitHub

✖ io.quarkus.vertx.http.testrunner.brokenonly.TestBrokenOnlyTestCase.testBrokenOnlyMode - More details - Source on GitHub

✖ io.quarkus.vertx.http.testrunner.includes.ExcludePatternTestCase.checkTestsAreRun - More details - Source on GitHub

✖ io.quarkus.vertx.http.testrunner.includes.IncludePatternTestCase.checkTestsAreRun - More details - Source on GitHub

✖ io.quarkus.vertx.http.testrunner.tags.ExcludeTagsTestCase.checkTestsAreRun - More details - Source on GitHub

✖ io.quarkus.vertx.http.testrunner.tags.IncludeTagsTestCase.checkTestsAreRun - More details - Source on GitHub

FroMage
FroMage approved these changes May 5, 2021
View reviewed changes
Copy link
Member

@FroMage FroMage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but CI don't look too happy.

@mkouba
Dev UI - handle file: protocol when locating /dev-templates
54dab3a 
- resolves quarkusio#16699
- this is useful if you run an example app in dev mode and this app is
part of a multi-module project which also declares the extension
- we just try to locate the pom.properties file in the
target/maven-archiver directory
- this hack will not work if addMavenDescriptor=false or if the
pomPropertiesFile is overriden
@mkouba mkouba added the triage/waiting-for-ci Ready to merge when CI successfully finishes label May 6, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented May 6, 2021 •
edited
Loading

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 54dab3a

Status Name Step Test failures Logs Raw logs
✔️ JVM Tests - JDK 11
✖ JVM Tests - JDK 11 Windows Build ⚠️ Check → Logs Raw logs
✔️ JVM Tests - JDK 15

@quarkus-bot
Copy link

quarkus-bot bot commented May 6, 2021 •
edited
Loading

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 54dab3a

Status Name Step Test failures Logs Raw logs
✔️ JVM Tests - JDK 11
✖ JVM Tests - JDK 11 Windows Build ⚠️ Check → Logs Raw logs
✔️ JVM Tests - JDK 15

@mkouba mkouba merged commit 9684326 into quarkusio:main May 7, 2021
@quarkus-bot quarkus-bot bot added this to the 2.0 - main milestone May 7, 2021
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label May 7, 2021
mkouba added a commit to mkouba/quarkus that referenced this pull request Jun 16, 2021
@mkouba
Dev UI - handle file protocol for DevConsoleRuntimeTemplateInfoBuildItem
3260b9b 
- resolves quarkusio#17915
- follows up on quarkusio#17007
@mkouba mkouba mentioned this pull request Jun 16, 2021
Merged
gsmet pushed a commit to gsmet/quarkus that referenced this pull request Jun 21, 2021
@mkouba @gsmet
Dev UI - handle file protocol for DevConsoleRuntimeTemplateInfoBuildItem
860c981 
- resolves quarkusio#17915
- follows up on quarkusio#17007

(cherry picked from commit 3260b9b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FroMage FroMage FroMage approved these changes

Assignees
No one assigned
Labels
area/core area/dev-ui area/vertx
Projects
None yet
Milestone
2.0.0.Alpha3
Development

Successfully merging this pull request may close these issues.

Dev UI does not use embedded.html when extension module is in same project as application
2 participants
@mkouba @FroMage